Improve exception handling in the failed health checks#676
Open
xstefank wants to merge 1 commit intosmallrye:mainfrom
Open
Improve exception handling in the failed health checks#676xstefank wants to merge 1 commit intosmallrye:mainfrom
xstefank wants to merge 1 commit intosmallrye:mainfrom
Conversation
Signed-off-by: xstefank <xstefank122@gmail.com>
Member
Author
|
@turing85 maybe you could also take a look and help me adjust this new API if needed? |
jmartisk
reviewed
Jan 7, 2026
| if (optionalUncheckedExceptionDataStyle.isPresent()) { | ||
| HealthLogging.logger | ||
| .warn("Configuration property \"io.smallrye.health.uncheckedExceptionDataStyle\" is deprecated. Use " + | ||
| "\"io.smallrye.health.exception-log-type\" and \"io.smallrye.health.exception.errorid.detail\" instead."); |
Member
There was a problem hiding this comment.
Would this deserve a piece of documentation? I don't think io.smallrye.health.exception-log-type and io.smallrye.health.exception.errorid.detail properties are documented? How would the user know how to use them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #669