Add side aesthetic to control segment attachment point on label bounding box#281
Open
arkriloth0 wants to merge 4 commits into
Open
Add side aesthetic to control segment attachment point on label bounding box#281arkriloth0 wants to merge 4 commits into
arkriloth0 wants to merge 4 commits into
Conversation
Owner
|
Would it be possible to include a screenshot here so we can see what the changes look like in a real plot? |
Author
Owner
|
Very nice! Thank you. I'll look over the code and consider merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
sideaesthetic togeom_text_repelandgeom_label_repelthatcontrols which side of the label bounding box the connecting segment attaches to
"top","right","bottom","left"0(automatic, existing behaviour unchanged)Motivation
When labels are nudged to a margin, segments should consistently attach to the
edge of the label that faces the data. Without
side, the attachment point ischosen geometrically — which can result in some segments attaching to the
left/right edge while others attach to the top or bottom, producing an uneven
appearance. Setting
sideenforces a uniform attachment edge across all labels,giving a cleaner result.
Example