Refactor: Extract block capturing logic to helper method#975
Merged
minad merged 1 commit intoslim-template:mainfrom Dec 21, 2025
Merged
Refactor: Extract block capturing logic to helper method#975minad merged 1 commit intoslim-template:mainfrom
minad merged 1 commit intoslim-template:mainfrom
Conversation
Extracted the block capturing logic from build_tag into a new private method capture_block_content. This resolves the TODO comment about creating a helper for universal capturing, improving code readability and maintainability. The new method encapsulates the logic for choosing between Rails' capture method (when disable_capture is true) and Slim's native yielding, making it reusable and easier to maintain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted the block capturing logic from build_tag into a new private method capture_block_content. This resolves the TODO comment about creating a helper for universal capturing, improving code readability and maintainability.
The new method encapsulates the logic for choosing between Rails' capture method (when disable_capture is true) and Slim's native yielding, making it reusable and easier to maintain.