-
Notifications
You must be signed in to change notification settings - Fork 33
feat: add slack docs search subcommand #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lukegalbraithrussell
wants to merge
10
commits into
main
Choose a base branch
from
docs-search-subcommand
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f248043
go
lukegalbraithrussell 94c8a90
refactoring
lukegalbraithrussell d7bbb84
go
lukegalbraithrussell 727d7ce
more test coverage
lukegalbraithrussell e1b0d80
Merge branch 'main' into docs-search-subcommand
lukegalbraithrussell 4985713
refactor
lukegalbraithrussell 91b5ac5
remove deprecation warning
lukegalbraithrussell 086b9e5
go
lukegalbraithrussell 2bf8133
Merge branch 'main' into docs-search-subcommand
lukegalbraithrussell 47613d0
test
lukegalbraithrussell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| // Copyright 2022-2026 Salesforce, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package docs | ||
|
|
||
| import ( | ||
| "context" | ||
| "encoding/json" | ||
| "fmt" | ||
| "strings" | ||
|
|
||
| "github.com/slackapi/slack-cli/internal/shared" | ||
| "github.com/slackapi/slack-cli/internal/slackerror" | ||
| "github.com/slackapi/slack-cli/internal/slacktrace" | ||
| "github.com/slackapi/slack-cli/internal/style" | ||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| type searchConfig struct { | ||
| output string | ||
| limit int | ||
| } | ||
|
|
||
| func makeAbsoluteURL(relativeURL string) string { | ||
| if strings.HasPrefix(relativeURL, "http") { | ||
| return relativeURL | ||
| } | ||
| return docsURL + relativeURL | ||
| } | ||
|
|
||
| func NewSearchCommand(clients *shared.ClientFactory) *cobra.Command { | ||
| cfg := &searchConfig{} | ||
|
|
||
| cmd := &cobra.Command{ | ||
| Use: "search <query>", | ||
| Short: "Search Slack developer docs", | ||
| Long: "Search the Slack developer docs and return results in text, JSON, or browser format", | ||
| Example: style.ExampleCommandsf([]style.ExampleCommand{ | ||
| { | ||
| Meaning: "Search docs and return text results", | ||
| Command: "docs search \"Block Kit\"", | ||
| }, | ||
| { | ||
| Meaning: "Search docs and open results in browser", | ||
| Command: "docs search \"webhooks\" --output=browser", | ||
| }, | ||
| { | ||
| Meaning: "Search docs with limited JSON results", | ||
| Command: "docs search \"api\" --output=json --limit=5", | ||
| }, | ||
| }), | ||
| Args: cobra.MinimumNArgs(1), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| return runDocsSearchCommand(clients, cmd, args, cfg) | ||
| }, | ||
| } | ||
|
|
||
| cmd.Flags().StringVar(&cfg.output, "output", "text", "output format: text, json, browser") | ||
| cmd.Flags().IntVar(&cfg.limit, "limit", 20, "maximum number of search results to return (only applies with --output=json and --output=text)") | ||
|
|
||
| return cmd | ||
| } | ||
|
|
||
| func runDocsSearchCommand(clients *shared.ClientFactory, cmd *cobra.Command, args []string, cfg *searchConfig) error { | ||
| ctx := cmd.Context() | ||
|
|
||
| query := strings.Join(args, " ") | ||
|
|
||
| switch cfg.output { | ||
| case "json": | ||
| return fetchAndOutputSearchResults(ctx, clients, query, cfg.limit) | ||
| case "text": | ||
| return fetchAndOutputTextResults(ctx, clients, query, cfg.limit) | ||
| case "browser": | ||
| docsSearchURL := buildDocsSearchURL(query) | ||
|
|
||
| clients.IO.PrintInfo(ctx, false, "\n%s", style.Sectionf(style.TextSection{ | ||
| Emoji: "books", | ||
| Text: "Docs Search", | ||
| Secondary: []string{ | ||
| docsSearchURL, | ||
| }, | ||
| })) | ||
|
|
||
| clients.Browser().OpenURL(docsSearchURL) | ||
| clients.IO.PrintTrace(ctx, slacktrace.DocsSearchSuccess, query) | ||
|
|
||
| return nil | ||
| default: | ||
| return slackerror.New(slackerror.ErrInvalidFlag).WithMessage( | ||
| "Invalid output format: %s", cfg.output, | ||
| ).WithRemediation( | ||
| "Use one of: text, json, browser", | ||
| ) | ||
| } | ||
| } | ||
|
|
||
lukegalbraithrussell marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| func fetchAndOutputSearchResults(ctx context.Context, clients *shared.ClientFactory, query string, limit int) error { | ||
| searchResponse, err := clients.API().DocsSearch(ctx, query, limit) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| for i := range searchResponse.Results { | ||
| searchResponse.Results[i].URL = makeAbsoluteURL(searchResponse.Results[i].URL) | ||
| } | ||
|
|
||
| encoder := json.NewEncoder(clients.IO.WriteOut()) | ||
| encoder.SetIndent("", " ") | ||
| if err := encoder.Encode(searchResponse); err != nil { | ||
| return slackerror.New(slackerror.ErrUnableToParseJSON).WithRootCause(err) | ||
| } | ||
|
|
||
| clients.IO.PrintTrace(ctx, slacktrace.DocsSearchSuccess, query) | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func fetchAndOutputTextResults(ctx context.Context, clients *shared.ClientFactory, query string, limit int) error { | ||
| searchResponse, err := clients.API().DocsSearch(ctx, query, limit) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| for _, result := range searchResponse.Results { | ||
| absoluteURL := makeAbsoluteURL(result.URL) | ||
| fmt.Fprintf(clients.IO.WriteOut(), "%s\n%s\n\n", result.Title, absoluteURL) | ||
| } | ||
|
|
||
| clients.IO.PrintTrace(ctx, slacktrace.DocsSearchSuccess, query) | ||
|
|
||
| return nil | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.