Skip to content

build: use minimum support @types/node@18 in development#2531

Merged
zimeg merged 7 commits intomainfrom
types18
Mar 12, 2026
Merged

build: use minimum support @types/node@18 in development#2531
zimeg merged 7 commits intomainfrom
types18

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Mar 3, 2026

Summary

This PR sets the @types/node package to ^18 in development dependencies to ensure patterns used in code are supported with our minimum supported node version 👾

Requirements

@zimeg zimeg self-assigned this Mar 3, 2026
@zimeg zimeg requested a review from a team as a code owner March 3, 2026 21:53
@zimeg zimeg added semver:patch area:typescript issues that specifically impact using the package from typescript projects pkg:web-api applies to `@slack/web-api` pkg:rtm-api applies to `@slack/rtm-api` pkg:webhook applies to `@slack/webhook` pkg:logger applies to `@slack/logger` pkg:types applies to `@slack/types` pkg:oauth applies to `@slack/oauth` pkg:socket-mode applies to `@slack/socket-mode` pkg:cli-hooks applies to `@slack/cli-hooks` pkg:cli-test applies to `@slack/cli-test` labels Mar 3, 2026
@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2026

⚠️ No Changeset found

Latest commit: e9fccd4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.67%. Comparing base (a2eb4be) to head (e9fccd4).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2531   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files          82       82           
  Lines       14994    14994           
  Branches      508      508           
=======================================
  Hits        13596    13596           
  Misses       1373     1373           
  Partials       25       25           
Flag Coverage Δ
cli-hooks 90.67% <ø> (ø)
cli-test 90.67% <ø> (ø)
logger 90.67% <ø> (ø)
oauth 90.67% <ø> (ø)
socket-mode 90.67% <ø> (ø)
web-api 90.67% <ø> (ø)
webhook 90.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great 💯 thanks for working on this

One thing before merging ⏲️ should we also update the @dependabot config file to ignore major version bump of @type/node similar to what we do in BoltJS

    ignore:
      - dependency-name: "@types/node"
        versions:
          - "19.x"
          - "20.x"
          - "21.x"
          - "22.x"
          - "23.x"
          - "24.x"
          - "25.x"

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Great suggestion @WilliamBergamin! Otherwise, looks good to go!

zimeg and others added 2 commits March 12, 2026 15:27
Co-authored-by: William Bergamin <wbergamin@salesforce.com>
@zimeg
Copy link
Member Author

zimeg commented Mar 12, 2026

@WilliamBergamin @mwbrooks I appreciate these reviews so much! Thank you for making maintenance ongoing better 🎁 ✨

I'll merge this now to soon start testing node24 in CI!

@zimeg zimeg enabled auto-merge (squash) March 12, 2026 22:33
@zimeg zimeg merged commit bd44fbb into main Mar 12, 2026
11 checks passed
@zimeg zimeg deleted the types18 branch March 12, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:typescript issues that specifically impact using the package from typescript projects pkg:cli-hooks applies to `@slack/cli-hooks` pkg:cli-test applies to `@slack/cli-test` pkg:logger applies to `@slack/logger` pkg:oauth applies to `@slack/oauth` pkg:rtm-api applies to `@slack/rtm-api` pkg:socket-mode applies to `@slack/socket-mode` pkg:types applies to `@slack/types` pkg:web-api applies to `@slack/web-api` pkg:webhook applies to `@slack/webhook` semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants