Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2531 +/- ##
=======================================
Coverage 90.67% 90.67%
=======================================
Files 82 82
Lines 14994 14994
Branches 508 508
=======================================
Hits 13596 13596
Misses 1373 1373
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
WilliamBergamin
left a comment
There was a problem hiding this comment.
These changes look great 💯 thanks for working on this
One thing before merging ⏲️ should we also update the @dependabot config file to ignore major version bump of @type/node similar to what we do in BoltJS
ignore:
- dependency-name: "@types/node"
versions:
- "19.x"
- "20.x"
- "21.x"
- "22.x"
- "23.x"
- "24.x"
- "25.x"
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Great suggestion @WilliamBergamin! Otherwise, looks good to go!
Co-authored-by: William Bergamin <wbergamin@salesforce.com>
|
@WilliamBergamin @mwbrooks I appreciate these reviews so much! Thank you for making maintenance ongoing better 🎁 ✨ I'll merge this now to soon start testing |
Summary
This PR sets the
@types/nodepackage to^18in development dependencies to ensure patterns used in code are supported with our minimum supportednodeversion 👾Requirements