Fix #2701 #2702
Open
Fix #2701 #2702
+59
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display the correct class implementation in case of duplication (Fix #2701).
When adding a class already present in the mappings of
RootNode, compare the dex file names are now compared to select the right class.The GUI list classes from the
JavaPackage, which contains all classes implementation and appears to select the last one (?). Fixing this is a little tricky because having all classes inJavaPackagemight be the desired/expected behavior, but it feels strange to perform additional computations from outside an API class to select the right class, so I added another attribute toJavaPackagelisting classes without the duplicates.They are probably other places in the code that select an arbitrary implementation instead of the one used at runtime, but this fix the issue for files generated by the cli and the classes displayed by the gui from the tree menu.