fix: resolve drag-selection jumping issue on desktop#2702
Open
nandin9 wants to merge 1 commit intosingerdmx:masterfrom
Open
fix: resolve drag-selection jumping issue on desktop#2702nandin9 wants to merge 1 commit intosingerdmx:masterfrom
nandin9 wants to merge 1 commit intosingerdmx:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Problem:When there are multiple lines of text, dragging to select from top to bottom causes the editor to jump back to the first line of the selection.
The Solution:Wrapped the
bringIntoViewlogic inWidgetsBinding.instance.addPostFrameCallback. This ensures the scroll position is calculated and updated only after the layout is stable and the new caret position is ready.Related Issues
Fixes #2697, Fixes #1642
Type of Change