Skip to content

Conversation

@satotoshitaka11
Copy link
Contributor

Description

Add support for BoxDecoration in DefaultTextBlockStyle for the header attribute. This allows developers to customize headers with borders, background colors, and other styles. Related to #2428.

Related Issues

Type of Change

  • Feature: New functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Refactor: Code reorganization, no behavior change.
  • Breaking: Alters existing functionality and requires updates.
  • 🧪 Tests: New or modified tests
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Build/configuration changes.

Copy link
Collaborator

@EchoEllet EchoEllet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

Unfortunately, we can't accept PRs that change too much to add new features as explained in the contributing guide, mainly because we have too many issues, and regressions and we don't have a good coverage.

Copy link
Collaborator

@CatHood0 CatHood0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@EchoEllet EchoEllet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, LGTM.

@EchoEllet EchoEllet merged commit f376f72 into singerdmx:master Feb 24, 2025
chaosue pushed a commit to chaosue/flutter-quill that referenced this pull request Mar 3, 2025
…ute (singerdmx#2438)

* feat: Enable BoxDecoration for DefaultTextBlockStyle of header Attribute

---------

Co-authored-by: Ellet <[email protected]>
CatHood0 pushed a commit to CatHood0/flutter-quill that referenced this pull request Mar 12, 2025
…ute (singerdmx#2438)

* feat: Enable BoxDecoration for DefaultTextBlockStyle of header Attribute

---------

Co-authored-by: Ellet <[email protected]>
wangjinshan pushed a commit to wangjinshan/flutter-quill that referenced this pull request Apr 29, 2025
* master: (83 commits)
  Add copyWith methods to DefaultStyles, HorizontalSpacing, and VerticalSpacing (singerdmx#2550)
  docs: update migration guide to relfect singerdmx#2529
  chore(release): prepare to publish 11.4.0
  feat: allow to override link validation check, and accept mailto and other links by default (singerdmx#2525)
  chore(release): prepare to publish 11.3.0
  Fix selection in readOnly mode, Add magnifier via RawMagnifier widget (singerdmx#2529)
  Clarify platform support of QuillEditorConfig.onKeyPressed (singerdmx#2542)
  chore(release): prepare to publish 11.2.0
  feat: cache for toPlainText in Document to avoid unnecessary text computing (singerdmx#2482)
  chore(example): update deps
  chore(release): prepare to publish 11.1.2
  fix: QuillEditor doesn't respect the system keyboard brightness by default on iOS (singerdmx#2522)
  chore(release): prepare to publish flutter_quill_test
  chore(release): prepare to publish 11.1.1
  Chore: general improvements in flutter_quill_tests API (singerdmx#2512)
  Explicitly schedule frame on secondary click. (singerdmx#2507)
  chore(release): prepare to publish 11.1.0
  fix: unpredictable endless loop of '_handleFocusChanged' in the phase of page route changing when editor is set to readonly. (singerdmx#2488)
  feat: Enable BoxDecoration for DefaultTextBlockStyle of header Attribute (singerdmx#2438)
  Expose Rule type so that Document.setCustomRules can be used (singerdmx#2484)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants