Skip to content

Conversation

@EchoEllet
Copy link
Collaborator

Description

Avoid hardcoding the branch name (master) in publish.yml to allow publishing a pre-release of release/v11

Previously, I hardcoded the branch name master to fix a CI failure and left a TODO in the publish.yml since we didn't need to publish a release from a branch other than master and it's also not a priority and I wanted to focus on other issues.

This allows maintainers to publish a release from any branch.

Type of Change

  • New feature: Adds new functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Code refactor: Code restructuring that does not affect behavior.
  • Breaking change: Alters existing functionality and requires updates.
  • 🧪 Tests: Adds new tests or modifies existing tests.
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Changes to build or deploy processes.

@EchoEllet EchoEllet force-pushed the ci/publish-avoid-master-hardcode branch 2 times, most recently from de8b2c0 to 1d78249 Compare October 26, 2024 16:47
@EchoEllet EchoEllet force-pushed the ci/publish-avoid-master-hardcode branch from 1d78249 to 5200ab4 Compare October 26, 2024 16:54
@EchoEllet EchoEllet closed this Oct 26, 2024
@EchoEllet EchoEllet deleted the ci/publish-avoid-master-hardcode branch October 26, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants