fix(ios): link menu action Cupertino modal popup now does NOT use root nav #2332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igtaor This is to fix a bug where when using nested navigators the modal popup wouldn't pop. This also brings the behaviour into parity with the Android/Material equivalent.
EchoEllet
approved these changes
Oct 23, 2024
Collaborator
EchoEllet
left a comment
EchoEllet
left a comment
There was a problem hiding this comment.
LGTM. I'm unsure why we're using the Cupertino library for a modal popup when most of our UI relies on the Material library across all platforms.
Collaborator
|
Can address this comment? |
Collaborator
|
Merged but there's no guarantee the fix will remain since we don't have a related test for the bug fix. Thanks for your contributions. |
EchoEllet
changed the title
CatHood0
pushed a commit
to CatHood0/flutter-quill
that referenced
this pull request
Oct 28, 2024
…singerdmx#2332) * fix: link menu action cupertino modal popup now does not use root navigator This is to fix a bug where when using nested navigators the modal popup wouldn't pop. This also brings the behavior into parity with the Android/Material equivalent. * chore: add comment referencing bug fix singerdmx#1170 --------- Co-authored-by: Doug Todd <[email protected]> Co-authored-by: Ellet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to fix a bug where when using nested navigators the modal popup wouldn't pop (instead, the underlying pages would). This also brings the behaviour into parity with the Android/Material equivalent.
Related Issues
Type of Change