refactor(crypto): use awl-lc-rs in ecdsa module.#534
Draft
jvanz wants to merge 1 commit intosigstore:mainfrom
Draft
refactor(crypto): use awl-lc-rs in ecdsa module.#534jvanz wants to merge 1 commit intosigstore:mainfrom
jvanz wants to merge 1 commit intosigstore:mainfrom
Conversation
jvanz
force-pushed
the
switch-to-aws-lc-rs
branch
4 times, most recently
from
36c6d14 to
e90cbbe
Compare
Updates the code that generates, parses and signs using ECDSA keys to use the aws-lc-rs crate. Therefore, all the references to other crypto libraries has been removed. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
jvanz
force-pushed
the
switch-to-aws-lc-rs
branch
from
e90cbbe to
240ccde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the code that generates, parses and signs using ECDSA keys to use the aws-lc-rs crate. Therefore, all the references to other crypto libraries has been removed.
The first change the starts to fix the issue #307.
Warning
Remeber this is not a complete change. It's the first of a series of changes in the crypto module to replace crypto libraries in favor of
aws-lc-rs. See the proposed change hereRelease Note
The
EcdsaKeysstruct now requires the callers to algorithm used in the keys they want to parse. This is a required argument to the underlingaws-lc-rscrate.