Update charts to respect create: false for service accounts#1115
Open
ghost wants to merge 9 commits intosigstore:mainfrom
Open
Update charts to respect create: false for service accounts#1115ghost wants to merge 9 commits intosigstore:mainfrom
ghost wants to merge 9 commits intosigstore:mainfrom
Conversation
Signed-off-by: Célia Vytrac <celia@gameplan.tech>
Signed-off-by: Célia Vytrac <celia@gameplan.tech>
Signed-off-by: Célia Vytrac <celia@gameplan.tech>
Signed-off-by: Célia Vytrac <celia@gameplan.tech>
ghost
changed the title
Signed-off-by: Célia Vytrac <celia@gameplan.tech>
Signed-off-by: Célia Vytrac <celia@gameplan.tech>
Signed-off-by: Célia Vytrac <celia@gameplan.tech>
Signed-off-by: Célia Vytrac <celia@gameplan.tech>
ghost
marked this pull request as ready for review
Signed-off-by: Célia Vytrac <celia@gameplan.tech>
ghost
force-pushed
the
fix/conditional-sa
branch
from
dbdb55a to
b31e467
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This aligns these charts with other charts in the repo (e.g., rekor-tiles, ctlog-tiles, trillian) that implement the conditional pattern.
Affected charts:
Existing or Associated Issue(s)
Fixes #1114
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.