feat(kfd): group provider tools under eks (back-compatible)#526
Open
nutellinoit wants to merge 1 commit into
Open
feat(kfd): group provider tools under eks (back-compatible)#526nutellinoit wants to merge 1 commit into
nutellinoit wants to merge 1 commit into
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary 💡
Groups the kfd.yaml
toolsper provider:opentofuandfuryagentare now pinned undertools.eks(they are EKS-only). The change is backward compatible — the model still acceptsthe previous layout (these tools, and the legacy
terraform, undertools.common), so olderdistributions keep working with a furyctl that reads the new location first.
Related furyctl PR: sighupio/furyctl#672
Pre-release tag for furyctl to consume:
v1.34.2-rc.3Description 📝
kfd.yaml:opentofuandfuryagentmoved undertools.eks(next toawscli);tools.commonkeeps the truly common tools (kubectl, kustomize, yq, helm, helmfile, kapp).
pkg/apis/config/model.go:KFDToolsEksgains optionalopentofu/furyagent.KFDToolsCommonkeeps
opentofu/furyagent/terraformas optional (no longerrequired) for backwardcompatibility with distributions < 1.34.2.
model.gois hand-written, no regeneration.Breaking Changes 💔
None. The model is additive: new distributions pin under
tools.eks, older ones keeptools.common,and furyctl resolves provider-first with a common fallback (see related PR). Requires the
v1.34.2-rc.3pre-release for furyctl.Tests performed 🧪
go build ./...v1.34.2-rc.3: EKS reads tools fromtools.eks; OnPremisesgets only the common tools (new layout) and still resolves opentofu/furyagent from
tools.commonon older distributions (cold-cache e2e against v1.34.1)