fix(echarts): use Siemens font

[nuke-ellington]

💡 What is the current behavior?

GitHub Issue Number: #

🆕 What is the new behavior?

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

• 🦮 Accessibility (a11y) features were implemented
• 🗺️ Internationalization (i18n) - no hard coded strings
• 📲 Responsiveness - components handle viewport changes and content overflow gracefully
• 📕 Add or update a Storybook story
• 📄 Documentation was reviewed/updated siemens/ix-docs
• 🧪 Unit tests were added/updated and pass (pnpm test)
• 📸 Visual regression tests were added/updated and pass (Guide)
• 🧐 Static code analysis passes (pnpm lint)
• 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

[changeset-bot]

🦋 Changeset detected

Latest commit: 42a73c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@siemens/ix-echarts	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gemini-code-assist]

Summary of Changes

Hello @nuke-ellington, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the typography within the ECharts themes by implementing the 'Siemens Sans' font family across all relevant text elements. This change enhances visual consistency throughout the charts and streamlines theme management by consolidating text style definitions into reusable constants.

Highlights

• Font Standardization: The 'Siemens Sans' font family has been consistently applied across all ECharts themes (brand-dark, brand-light, classic-dark, classic-light) to ensure a unified typographic appearance.
• Text Style Refactoring: A textStyleDefault constant was introduced in each theme file to centralize font family and color definitions, improving maintainability and consistency for various text elements like titles, legends, and tooltips.
• Theme Builder JSON Updates: The seriesCnt property in the ECharts theme builder JSON files (brand-dark-tb.json, brand-light-tb.json, classic-dark-tb.json, classic-light-tb.json) was updated from a number to a string type, and a minor color adjustment was made in brand-dark-tb.json.

Changelog

• packages/echarts/src/themes/brand-dark.ts
  • Introduced a textStyleDefault constant to define common font styles.
  • Applied textStyleDefault to theme.textStyle, title.textStyle, title.subtextStyle, legend.textStyle, tooltip.textStyle, and nameTextStyle.
• packages/echarts/src/themes/brand-light.ts
  • Introduced a textStyleDefault constant to define common font styles.
  • Applied textStyleDefault to theme.textStyle, title.textStyle, title.subtextStyle, legend.textStyle, tooltip.textStyle, and nameTextStyle.
• packages/echarts/src/themes/builder/brand-dark-tb.json
  • Updated the seriesCnt property from a number to a string type.
  • Modified one color value within the theme's color array.
• packages/echarts/src/themes/builder/brand-light-tb.json
  • Updated the seriesCnt property from a number to a string type.
• packages/echarts/src/themes/builder/classic-dark-tb.json
  • Updated the seriesCnt property from a number to a string type.
• packages/echarts/src/themes/builder/classic-light-tb.json
  • Updated the seriesCnt property from a number to a string type.
• packages/echarts/src/themes/classic-dark.ts
  • Introduced a textStyleDefault constant to define common font styles.
  • Applied textStyleDefault to theme.textStyle, title.textStyle, title.subtextStyle, and legend.textStyle.
  • Added fontFamily: 'Siemens Sans, sans-serif' to tooltip.textStyle.
• packages/echarts/src/themes/classic-light.ts
  • Introduced a textStyleDefault constant to define common font styles.
  • Applied textStyleDefault to theme.textStyle, title.textStyle, title.subtextStyle, and legend.textStyle.
  • Added fontFamily: 'Siemens Sans, sans-serif' to tooltip.textStyle.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request successfully introduces the Siemens font to ECharts themes by defining a "textStyleDefault" constant and applying it across various text style configurations in the "brand-dark.ts" and "brand-light.ts" theme files. This is a good step towards standardizing font usage and improving maintainability. However, there are a couple of inconsistencies that should be addressed for better code quality. Specifically, the "seriesCnt" property in the JSON theme builder files has been changed from a number to a string, which could lead to type mismatches. Additionally, the application of "textStyleDefault" in "classic-dark.ts" and "classic-light.ts" for "tooltip.textStyle" is inconsistent with its usage for other text styles like "title" and "legend".

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud