Fix #10870: Guard null IRNameHintDecoration in mesh shader legalization#10914
Merged
kaizhangNV merged 1 commit intomasterfrom Apr 23, 2026
Merged
Fix #10870: Guard null IRNameHintDecoration in mesh shader legalization#10914kaizhangNV merged 1 commit intomasterfrom
kaizhangNV merged 1 commit intomasterfrom
Conversation
The obfuscation pass strips IRNameHintDecoration from IR instructions. legalizeMeshOutputParam() and legalizeMeshPayloadInputParam() in the GLSL legalization pass unconditionally dereferenced the decoration, causing a segfault when compiling mesh shaders with -obfuscate. Add null-guards matching the pattern already used at four other sites in the same file. Fixes #10870
jhelferty-nv
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When compiling a mesh shader with
-obfuscate, the obfuscation pass stripsIRNameHintDecorationfrom IR instructions. The GLSL legalization pass'slegalizeMeshOutputParam()andlegalizeMeshPayloadInputParam()then crash (segfault) by unconditionally dereferencing the null result offindDecoration<IRNameHintDecoration>().This patch adds null-guards matching the pattern already used at four other sites in the same file.
Fixes #10870
Changes
source/slang/slang-ir-glsl-legalize.cpp: GuardfindDecoration<IRNameHintDecoration>()with null-check inlegalizeMeshOutputParam()(line 3527) andlegalizeMeshPayloadInputParam()(line 3147), matching the existing pattern at lines 2170, 2239, 2966, 3015tests/pipeline/rasterization/mesh/obfuscate-mesh.slang: Regression test verifying mesh shader compiles with-obfuscatewithout crashingTest
Added
tests/pipeline/rasterization/mesh/obfuscate-mesh.slang— compiles a mesh shader to SPIR-V assembly with-obfuscateand verifies the entry point is emitted correctly.