Support coherent/globallycoherent in DescriptorHandle type modifier#10898
Open
nv-slang-bot[bot] wants to merge 1 commit intomasterfrom
Open
Support coherent/globallycoherent in DescriptorHandle type modifier#10898nv-slang-bot[bot] wants to merge 1 commit intomasterfrom
nv-slang-bot[bot] wants to merge 1 commit intomasterfrom
Conversation
Add CoherentModifierVal to the type modifier system so that DescriptorHandle<coherent T> and DescriptorHandle<globallycoherent T> compile instead of triggering ICE E99999 in checkTypeModifier(). Pipeline: GloballyCoherentModifier -> CoherentModifierVal -> CoherentAttr IR -> target-specific emit (HLSL: globallycoherent, GLSL: coherent, SPIRV: OpDecorate Coherent / coherent memory operands). Fixes #10852
Contributor
|
This PR modifies IR instruction definition files. Please review if you need to update the following constants in
These version numbers help ensure compatibility between different versions of compiled modules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CoherentModifierValto the type modifier system soDescriptorHandle<coherent T>andDescriptorHandle<globallycoherent T>compile instead of triggering ICE E99999tests/bugs/gh-10852.slangFixes #10852
Changes
CoherentModifierValclass +ASTBuilder::getCoherentModifierVal()factoryGloballyCoherentModifierincheckTypeModifier()(was the ICE source)CoherentAttrattribute inslang-ir-insts.lua+ stable namevisitCoherentModifierVal→kIROp_CoherentAttrCoherentAttr→globallycoherentprefixCoherentAttr→coherentprefixCoherentAttr→OpDecorate Coherent+ coherent memory operands for Vulkan memory model; unwrapIRAttributedTypein descriptor handle castTest
Added
tests/bugs/gh-10852.slang— verifies HLSL output includesgloballycoherent RWTexture2D<float4>for bothcoherentandgloballycoherentdescriptor handles.Labels
pr: non-breaking