seekable: Do validation of stream duration #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some seekable stream may not always have a duration so need to do validation of "metadata.duration" before using it to calculate seekable time ranges. Fixes: servo/servo#36748 Fixes: servo/servo#36809 Co-authored-by: Mitchel Stewart Signed-off-by: Andrei Volykhin <[email protected]>
jdm
approved these changes
May 20, 2025
tharkum
added a commit
to tharkum/servo
that referenced
this pull request
May 21, 2025
Summary: - Do validation of stream duration on seekable() method (servo/media#437) Testing: /html/semantics/embedded-content/* Fixes: servo#36748 Fixes: servo#36809 Signed-off-by: Andrei Volykhin <[email protected]>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
May 21, 2025
Summary: - Do validation of stream duration on seekable() method (servo/media#437) Testing: /html/semantics/embedded-content/* Fixes: #36748 Fixes: #36809 Signed-off-by: Andrei Volykhin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some seekable stream may not always have a duration so need to do validation
of "metadata.duration" before using it to calculate seekable time ranges.
Fixes: servo/servo#36748
Fixes: servo/servo#36809
Co-authored-by: Mitchel Stewart