extend player api to support seekable #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rayguo17 <[email protected]>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Apr 16, 2025
support seekable attribute in `htmlmediaelement`, modify `seek` algorithm to use `seekable` attribute. related [specs](https://html.spec.whatwg.org/multipage/media.html#dom-media-seekable) Testing: Run WPT Test Fixes: #22297 Will wait for servo/media#435 before turning this to ready for review. cc @jdm @xiaochengh Signed-off-by: rayguo17 <[email protected]>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Apr 16, 2025
support seekable attribute in `htmlmediaelement`, modify `seek` algorithm to use `seekable` attribute. related [specs](https://html.spec.whatwg.org/multipage/media.html#dom-media-seekable) Testing: Run WPT Test Fixes: #22297 Will wait for servo/media#435 before turning this to ready for review. cc @jdm @xiaochengh Signed-off-by: rayguo17 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extend player trait to have
fn seekable()if the source is
StreamType::Seekablereturn its duration, else returnbufferedranges.related spec,
Related Issue: servo/servo#22297
cc @jdm