-
Notifications
You must be signed in to change notification settings - Fork 47
Added some explanations for various crates. #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I am wondering if we should add some formulation to the distinction it makes. In some sense something like:
|
7ba8d8a to
ba22e2f
Compare
mrobinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list is pretty similar to what is in https://book.servo.org/design-documentation/directory-structure.html. Can you please integrate it into that page and rename it to "Project Structure?" Thank you.
mrobinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is getting there. One thing: after every colon decide if you want to capitalize the first letter of the phrase or not. I would say don't do it, but above all be consistent.
|
Thanks for the suggestion! I hope I got all of them. |
8fdba9e to
b50223e
Compare
Signed-off-by: Narfinger <[email protected]>
Signed-off-by: Narfinger <[email protected]>
Signed-off-by: Narfinger <[email protected]>
Signed-off-by: Narfinger <[email protected]>
|
@mrobinson any update on this? |
jdm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current framing is an improvement over what's on the page right now, so we should merge it.
Signed-off-by: Narfinger <[email protected]>
Signed-off-by: Narfinger [email protected]