Skip to content

Conversation

@Narfinger
Copy link
Contributor

Signed-off-by: Narfinger [email protected]

@Narfinger
Copy link
Contributor Author

I am wondering if we should add some formulation to the distinction it makes. In some sense something like:

  • Working on servo only crates is easy.
  • Working on mozilla crates needs special mozilla workflow
  • Working on crates that other people use needs extra care for api stability and other use cases.
    But I am not quite happy with such a formulation. Any ideas?

Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is pretty similar to what is in https://book.servo.org/design-documentation/directory-structure.html. Can you please integrate it into that page and rename it to "Project Structure?" Thank you.

Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting there. One thing: after every colon decide if you want to capitalize the first letter of the phrase or not. I would say don't do it, but above all be consistent.

@Narfinger
Copy link
Contributor Author

Thanks for the suggestion! I hope I got all of them.
One thing that I feel is still missing is something like this:
Original my reason for making this list was to show which crates people need to be more careful about updating and which parts can be a bit looser. But I don't quite know how to formulate that in a good sentence.

Signed-off-by: Narfinger <[email protected]>
Signed-off-by: Narfinger <[email protected]>
Signed-off-by: Narfinger <[email protected]>
Signed-off-by: Narfinger <[email protected]>
@Narfinger
Copy link
Contributor Author

@mrobinson any update on this?

Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current framing is an improvement over what's on the page right now, so we should merge it.

Signed-off-by: Narfinger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants