Skip to content

Conversation

@mordka
Copy link
Contributor

@mordka mordka commented Dec 9, 2020

This PR adds support for distribution id specified as an intrinsic function Fn::ImportValue
Example:

      - preExistingCloudFront:
          distributionId:
            'Fn::ImportValue': 'CloudFront-SomeDistribution::CloudFrontID'

Currently this is not supported and the following error is returned upon deploy

Expected params.Id to be a string

@flonn
Copy link

flonn commented Apr 19, 2021

As a workaround, @jgrumboe discovered that using outputs instead of exports work. https://www.serverless.com/framework/docs/providers/aws/guide/variables/#referencing-environment-variables

@brianantonelli
Copy link

Any chance of merging this down?

@horike37 horike37 merged commit ed639ec into serverless-operations:master Sep 30, 2021
@horike37
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants