Skip to content

updating to check if the number is actually a credit card using luhn #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 62 additions & 18 deletions src/Serilog.Enrichers.Sensitive/CreditCardMaskingOperator.cs
Original file line number Diff line number Diff line change
@@ -1,27 +1,71 @@
using System.Text.RegularExpressions;
using System;
using System.Text.RegularExpressions;

namespace Serilog.Enrichers.Sensitive
{
public class CreditCardMaskingOperator : RegexMaskingOperator
{
private const string CreditCardPartialReplacePattern =
@"(?<leading4>\d{4}(?<sep>[ -]?))(?<toMask>\d{4}\k<sep>*\d{2})(?<trailing6>\d{2}\k<sep>*\d{4})";
public class CreditCardMaskingOperator : IMaskingOperator
{
private const string CreditCardPartialReplacePattern =
@"(?<leading4>\d{4}(?<sep>[ -]?))(?<toMask>\d{4}\k<sep>*\d{2})(?<trailing6>\d{2}\k<sep>*\d{4})";

private const string CreditCardFullReplacePattern =
@"(?<toMask>\d{4}(?<sep>[ -]?)\d{4}\k<sep>*\d{4}\k<sep>*\d{4})";
private const string CreditCardFullReplacePattern =
@"(?<toMask>\d{4}(?<sep>[ -]?)\d{4}\k<sep>*\d{4}\k<sep>*\d{4})";

private readonly string _replacementPattern;
private readonly string _replacementPattern;

public CreditCardMaskingOperator() : this(true)
{
}
public CreditCardMaskingOperator() : this(true)
{
}

public CreditCardMaskingOperator(bool fullMask)
: base(fullMask ? CreditCardFullReplacePattern : CreditCardPartialReplacePattern, RegexOptions.IgnoreCase | RegexOptions.Compiled)
{
_replacementPattern = fullMask ? "{0}" : "${{leading4}}{0}${{trailing6}}";
}
public CreditCardMaskingOperator(bool fullMask)
{
_replacementPattern = fullMask ? "{0}" : "${{leading4}}{0}${{trailing6}}";
}

protected override string PreprocessMask(string mask) => string.Format(_replacementPattern, mask);
}
protected string PreprocessMask(string mask)
{
return string.Format(_replacementPattern, mask);
}

public MaskingResult Mask(string input, string mask)
{
var matches = Regex.Matches(input, _replacementPattern);
foreach (Match match in matches)
{
if (IsValidCreditCardNumber(match.Value))
{
// Perform masking
input = Regex.Replace(input, match.Value, m => PreprocessMask("XXXX-XXXX-XXXX-XXXX"));
return new MaskingResult { Match = true, Result = input };
}
}
return MaskingResult.NoMatch;
}

private bool IsValidCreditCardNumber(string cardNumber)
{
// Remove non-numeric characters
var cleanCardNumber = Regex.Replace(cardNumber, "[^0-9]", "");

int sum = 0;
bool alternate = false;
for (int i = cleanCardNumber.Length - 1; i >= 0; i--)
{
var digit = int.Parse(cleanCardNumber[i].ToString());

if (alternate)
{
digit *= 2;
if (digit > 9)
{
digit = (digit % 10) + 1;
}
}
sum += digit;
alternate = !alternate;
}
// If the sum modulo 10 is 0, the number is valid according to the Luhn formula
return sum % 10 == 0;
}
}
}