Add decoding and encoding of ObjectIdentifier ASN.1 records
#1849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1849 +/- ##
==========================================
+ Coverage 82.96% 83.00% +0.04%
==========================================
Files 285 285
Lines 49063 49257 +194
Branches 10599 10459 -140
==========================================
+ Hits 40707 40888 +181
- Misses 7196 7567 +371
+ Partials 1160 802 -358
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
seladb
changed the title
ObjectIdentifier ASN.1 recordsObjectIdentifier ASN.1 records
tigercosmos
approved these changes
Jun 17, 2025
| std::vector<uint32_t> components; | ||
|
|
||
| uint8_t firstByte = data[currentByteIndex++]; | ||
| components.push_back(static_cast<uint32_t>(firstByte / 40)); |
There was a problem hiding this comment.
Consider explaining what the 40 magic number is in the comments.
There was a problem hiding this comment.
Added documentation here: d690947
| { | ||
| uint8_t byte = data[currentByteIndex++]; | ||
|
|
||
| currentComponentValue = (currentComponentValue << 7) | (byte & 0x7f); |
There was a problem hiding this comment.
Maybe leave some comments here? Like doing which step in the spec.
There was a problem hiding this comment.
Added documentation here: d690947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #1835, X509 certificates require support for ASN.1 records of type
ObjectIdentifier