Skip to content

Add decoding and encoding of UTCTime and GeneralizedTime ASN.1 records #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from

Conversation

seladb
Copy link
Owner

@seladb seladb commented May 30, 2025

As part of #1835, X509 certificates require support for ASN.1 records of UTCTime and GeneralizedTime

Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 99.15014% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.11%. Comparing base (d4bfc6a) to head (41b6d38).

Files with missing lines Patch % Lines
Packet++/src/Asn1Codec.cpp 98.20% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1837      +/-   ##
==========================================
+ Coverage   82.97%   83.11%   +0.14%     
==========================================
  Files         285      285              
  Lines       48968    49366     +398     
  Branches    10346    10426      +80     
==========================================
+ Hits        40630    41031     +401     
- Misses       7177     7193      +16     
+ Partials     1161     1142      -19     
Flag Coverage Δ
alpine320 75.33% <98.92%> (+0.23%) ⬆️
fedora42 75.43% <98.92%> (?)
macos-13 80.64% <96.39%> (+0.12%) ⬆️
macos-14 80.64% <96.39%> (+0.12%) ⬆️
macos-15 80.62% <96.39%> (+0.12%) ⬆️
mingw32 71.58% <95.34%> (+0.22%) ⬆️
mingw64 71.56% <95.34%> (+0.20%) ⬆️
npcap 85.09% <98.63%> (+0.09%) ⬆️
rhel94 75.20% <98.92%> (+0.24%) ⬆️
ubuntu2004 59.00% <96.71%> (+0.33%) ⬆️
ubuntu2004-zstd 59.09% <96.71%> (+0.31%) ⬆️
ubuntu2204 75.12% <98.92%> (?)
ubuntu2204-icpx 61.47% <60.00%> (-0.05%) ⬇️
ubuntu2404 75.39% <98.92%> (+0.25%) ⬆️
ubuntu2404-arm64 75.37% <98.92%> (+0.23%) ⬆️
unittest 83.11% <99.15%> (+0.14%) ⬆️
windows-2019 85.11% <98.63%> (+0.13%) ⬆️
windows-2022 85.12% <98.63%> (+0.09%) ⬆️
winpcap 85.26% <98.63%> (+0.09%) ⬆️
xdp 51.02% <98.92%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@seladb seladb marked this pull request as ready for review June 14, 2025 08:53
@seladb seladb requested a review from Dimi1010 June 15, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants