BUG: fix seccomp_export_bpf_mem out-of-bounds read#458
Closed
alyssais wants to merge 1 commit intoseccomp:mainfrom
Closed
BUG: fix seccomp_export_bpf_mem out-of-bounds read#458alyssais wants to merge 1 commit intoseccomp:mainfrom
alyssais wants to merge 1 commit intoseccomp:mainfrom
Conversation
*len is the length of the destination buffer, but program->blks is probably not anywhere near that long. It's already been checked above that BPF_PGM_SIZE(program) is less than or equal to *len, so that's the correct value to use here to avoid either reading or writing too much. I noticed this because tests/11-basic-basic_errors started failing on musl after e797591 ("all: add seccomp_precompute() functionality"). Signed-off-by: Alyssa Ross <hi@alyssa.is>
alyssais
changed the title
drakenclimber
approved these changes
Mar 10, 2025
Member
drakenclimber
left a comment
drakenclimber
left a comment
There was a problem hiding this comment.
Acked-by: Tom Hromatka <tom.hromatka@oracle.com>
pcmoore
changed the title
Member
|
Merged into main via e8dbc6b, keeping open until the backport to release-2.6 is complete. |
Member
|
Merged into release-2.6 via dd759e8, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*lenis the length of the destination buffer, butprogram->blksis probably not anywhere near that long. It's already been checked above thatBPF_PGM_SIZE(program)is less than or equal to*len, so that's the correct value to use here to avoid either reading or writing too much.I noticed this because tests/11-basic-basic_errors started failing on musl after e797591 ("all: add seccomp_precompute() functionality").