-
Notifications
You must be signed in to change notification settings - Fork 154
ci: add pinned minimum dependencies test job (#324) #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #334 +/- ##
=======================================
Coverage 95.18% 95.18%
=======================================
Files 5 5
Lines 436 436
Branches 76 76
=======================================
Hits 415 415
Misses 13 13
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@wRAR, could you please review this PR? |
|
It should be defined as a tox env.
I don't think this makes sense, tox wouldn't read those constraints. |
|
Have you missed my comment? |
|
I have reviewed your comment. While the Tox tests were missed locally, the checks are passing here on the PR. Please let me know if I am missing anything or if something is not working as expected, and I will take care of it. |
|
You may have missed the first line of it. This should be defined as a separate tox env that the new CI job runs. Please also add suitable version restrictions to |
…n-deps tox environment inheriting deps/commands from base
9226a6b to
580478d
Compare
|
Pushed the final changes! |
|
I have pushed the requested changes. |

Fixes #324
Pinned versions tested:
All tests pass locally under these constraints (tox -e py310: 393 passed, 2 skipped).