Skip to content

Conversation

@IkramKhanNiazi
Copy link
Contributor

@IkramKhanNiazi IkramKhanNiazi commented Jan 1, 2026

Fixes #324

Pinned versions tested:

  • cssselect==1.2.0
  • jmespath==1.0.0
  • lxml==5.1.0
  • packaging==23.0
  • w3lib==1.19.0

All tests pass locally under these constraints (tox -e py310: 393 passed, 2 skipped).

@codecov
Copy link

codecov bot commented Jan 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.18%. Comparing base (612e605) to head (8d54403).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #334   +/-   ##
=======================================
  Coverage   95.18%   95.18%           
=======================================
  Files           5        5           
  Lines         436      436           
  Branches       76       76           
=======================================
  Hits          415      415           
  Misses         13       13           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IkramKhanNiazi
Copy link
Contributor Author

@wRAR, could you please review this PR?
Thanks

@wRAR
Copy link
Member

wRAR commented Jan 1, 2026

It should be defined as a tox env.

All tests pass locally under these constraints (tox -e py310

I don't think this makes sense, tox wouldn't read those constraints.

@IkramKhanNiazi
Copy link
Contributor Author

[Ubuntu / Pinned minimum dependencies (Python 3.10) (pull_request)](https://github.com/scrapy/parsel/actions/runs/20637014680/job/59263370713?pr=334)

It’s working fine and has passed the checks as well. Let me know if I’m missing anything.

Screenshot 2026-01-01 at 3 49 09 PM

@wRAR
Copy link
Member

wRAR commented Jan 1, 2026

Have you missed my comment?

@IkramKhanNiazi
Copy link
Contributor Author

I have reviewed your comment. While the Tox tests were missed locally, the checks are passing here on the PR. Please let me know if I am missing anything or if something is not working as expected, and I will take care of it.

@wRAR
Copy link
Member

wRAR commented Jan 1, 2026

You may have missed the first line of it. This should be defined as a separate tox env that the new CI job runs.

Please also add suitable version restrictions to install_requires when they are missing.

…n-deps tox environment inheriting deps/commands from base
@IkramKhanNiazi
Copy link
Contributor Author

Pushed the final changes!

@IkramKhanNiazi
Copy link
Contributor Author

I have pushed the requested changes.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Specify minimum dependency versions and add a pinned CI job

2 participants