Add feastol numerics checks #997

Joao-Dionisio · 2025-05-17T14:10:25Z

Why the heck am I the SCIP-CI bot now?? O.o

EDIT: I ran generate-docs.sh yesterday, which sets the global user and email to the SCIP bot

src/pyscipopt/scip.pxi

src/pyscipopt/scip.pxd

src/pyscipopt/scip.pxi

CHANGELOG.md

tests/helpers/utils.py

tests/test_numerics.py

Co-authored-by: DominikKamp <[email protected]>

tests/helpers/utils.py

…d tests

CHANGELOG.md

src/pyscipopt/scip.pxd

src/pyscipopt/scip.pxi

tests/helpers/utils.py

tests/test_conshdlr.py

tests/helpers/utils.py

tests/test_conshdlr.py

DominikKamp · 2025-05-17T19:07:06Z

Otherwise, this is fine, thank you!

Co-authored-by: DominikKamp <[email protected]>

src/pyscipopt/scip.pxd

Co-authored-by: DominikKamp <[email protected]>

src/pyscipopt/scip.pxi

tests/test_conshdlr.py

tests/test_numerics.py

tests/helpers/utils.py

Co-authored-by: DominikKamp <[email protected]>

Joao-Dionisio · 2025-05-18T06:26:50Z

thanks for such a detailed review, Dominik!

Add feastol numerics checks

7424c82

Joao-Dionisio requested a review from DominikKamp May 17, 2025 14:10

typos

a93b3ab

Joao-Dionisio marked this pull request as draft May 17, 2025 14:17

scip-ci and others added 2 commits May 17, 2025 15:17

test

731cc7b

fixed?

af37755

Joao-Dionisio self-assigned this May 17, 2025

Joao-Dionisio marked this pull request as ready for review May 17, 2025 14:24

add locktype

bd0e6b5

DominikKamp reviewed May 17, 2025

View reviewed changes

src/pyscipopt/scip.pxi Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

src/pyscipopt/scip.pxi Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

src/pyscipopt/scip.pxd Outdated Show resolved Hide resolved

Joao-Dionisio added 2 commits May 17, 2025 15:35

add addVarLocksType

d1cce17

Dom's comments

a60ab43

Joao-Dionisio commented May 17, 2025

View reviewed changes

src/pyscipopt/scip.pxi Show resolved Hide resolved

typo

032d4be

DominikKamp reviewed May 17, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

tests/helpers/utils.py Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

tests/test_numerics.py Outdated Show resolved Hide resolved

Apply suggestions from code review

aa10bbf

Co-authored-by: DominikKamp <[email protected]>

Joao-Dionisio marked this pull request as draft May 17, 2025 15:23

DominikKamp reviewed May 17, 2025

View reviewed changes

tests/helpers/utils.py Outdated Show resolved Hide resolved

Joao-Dionisio added 2 commits May 17, 2025 18:07

relax, docstring, and locktype

17427ce

Add getNLocksDown, getNLocksUp, getNLocksUpType, getNLocksDownType an…

5056501

…d tests

DominikKamp reviewed May 17, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

src/pyscipopt/scip.pxd Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

src/pyscipopt/scip.pxd Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

src/pyscipopt/scip.pxd Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

src/pyscipopt/scip.pxd Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

src/pyscipopt/scip.pxd Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

src/pyscipopt/scip.pxd Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

src/pyscipopt/scip.pxd Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

src/pyscipopt/scip.pxi Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

src/pyscipopt/scip.pxi Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

src/pyscipopt/scip.pxi Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

src/pyscipopt/scip.pxi Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

tests/helpers/utils.py Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

tests/test_conshdlr.py Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

tests/helpers/utils.py Outdated Show resolved Hide resolved

DominikKamp reviewed May 17, 2025

View reviewed changes

tests/test_conshdlr.py Outdated Show resolved Hide resolved

Joao-Dionisio and others added 2 commits May 17, 2025 20:14

Apply suggestions from code review

4099286

Co-authored-by: DominikKamp <[email protected]>

lock tests

9457dc0

DominikKamp reviewed May 17, 2025

View reviewed changes

src/pyscipopt/scip.pxd Outdated Show resolved Hide resolved

Joao-Dionisio and others added 2 commits May 17, 2025 22:15

Apply suggestions from code review

fafb32a

Co-authored-by: DominikKamp <[email protected]>

dom's comments

e1e15b8

DominikKamp reviewed May 18, 2025

View reviewed changes

src/pyscipopt/scip.pxi Outdated Show resolved Hide resolved

DominikKamp reviewed May 18, 2025

View reviewed changes

src/pyscipopt/scip.pxi Outdated Show resolved Hide resolved

DominikKamp reviewed May 18, 2025

View reviewed changes

src/pyscipopt/scip.pxi Outdated Show resolved Hide resolved

DominikKamp reviewed May 18, 2025

View reviewed changes

tests/test_conshdlr.py Outdated Show resolved Hide resolved

DominikKamp reviewed May 18, 2025

View reviewed changes

tests/test_conshdlr.py Outdated Show resolved Hide resolved

DominikKamp reviewed May 18, 2025

View reviewed changes

tests/test_conshdlr.py Outdated Show resolved Hide resolved

DominikKamp reviewed May 18, 2025

View reviewed changes

tests/test_numerics.py Outdated Show resolved Hide resolved

DominikKamp reviewed May 18, 2025

View reviewed changes

tests/helpers/utils.py Outdated Show resolved Hide resolved

Joao-Dionisio and others added 2 commits May 18, 2025 07:21

Apply suggestions from code review

3385b08

Co-authored-by: DominikKamp <[email protected]>

store variable in model data

9513868

Joao-Dionisio marked this pull request as ready for review May 18, 2025 06:26

Joao-Dionisio merged commit eb32a20 into master May 18, 2025
2 checks passed

DominikKamp mentioned this pull request May 18, 2025

Adding constraints through a callback function #994

Closed

Add feastol numerics checks #997

Add feastol numerics checks #997

Uh oh!

Conversation

Joao-Dionisio commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DominikKamp commented May 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Joao-Dionisio commented May 18, 2025

Uh oh!

Uh oh!

Uh oh!

Joao-Dionisio commented May 17, 2025 •

edited

Loading