This repository was archived by the owner on Nov 24, 2018. It is now read-only.
pass client host and port to remote interface#193
Open
gorangajic wants to merge 1 commit intoschickling:masterfrom
Open
pass client host and port to remote interface#193gorangajic wants to merge 1 commit intoschickling:masterfrom
gorangajic wants to merge 1 commit intoschickling:masterfrom
Conversation
when chrome is running on some other port than default chromeless was failing silently
|
I can confirm that without this change, using remote host and port does not work properly, i.e. However, error is not raised when Chrome is also running on localhost with remote debugging port enabled. So i assume that it does the version check against the local instance but everything else works against remote Chrome instance as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when chrome is running on some other port than the default
chromeless was failing silently