chore(compiler): add top-level object dependency regression test - #26756
Open
nguyenyou wants to merge 1 commit into
Open
chore(compiler): add top-level object dependency regression test#26756nguyenyou wants to merge 1 commit into
nguyenyou wants to merge 1 commit into
Conversation
Add a focused Zinc callback test for the class file paired with a top-level object binary name. LLM assistance: Codex helped investigate and write the test; the callback data and targeted test result were reviewed locally. Co-Authored-By: Codex GPT-5.6 Sol (Extra High) <codex@openai.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a regression test for binary dependencies loaded from TASTy.
For a top-level object, the compiler reports binary name
example.Api$withApi.class; the defining file isApi$.class. Zinc can therefore detect a false classpath change and recompile downstream sources.The new test intentionally fails with
expected: Api$.class, actual: Api.class.Have you relied on LLM-based tools in this contribution?
Yes, extensively. I first noticed the problem while using Mill: changing one source file caused incremental compilation to recompile five files. I asked Codex GPT-5.6 Sol (Extra High) and Claude Fable 5 (High) to investigate.
Both reached the same diagnosis and agreed on this regression test. I verified their work by reproducing the behavior locally, reviewing the dependency callback output, and running the focused test.
How was the solution tested?
This PR does not include a fix. It adds a minimal regression test that reproduces the bug and intentionally fails on
main; CI should confirm the failure.I do not have sufficient expertise in this compiler area to propose a reliable fix. Instead of opening an issue with a separate reproducer, I am submitting the reproducer directly as a test so maintainers can investigate and use it to validate the eventual fix.
If the project prefers an issue before proceeding with this PR, I am happy to file one.