Experiment: Simplify SimpleIdentityMap/Set - #26713
Draft
SolalPirelli wants to merge 2 commits into
Draft
Conversation
SolalPirelli
commented
Aug 5, 2026
| map2(assocToString) mkString ("(", ", ", ")") | ||
| } | ||
| } | ||
| final class SimpleIdentityMap[K <: AnyRef, +V <: AnyRef](bindings: Array[AnyRef]) extends (K => V | Null) { |
Contributor
Author
There was a problem hiding this comment.
note for myself, can this be an AnyVal?
Member
|
Benchmarks started. Workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been a number of experiments recently around data structures in the compiler.
One learning is that megamorphic dispatch can make the "more efficient subclasses" pattern perform worse than having a single general-purpose structure.
So let's see what happens with this... Locally on
areWeFastYetit seems to make no difference.Have you relied on LLM-based tools in this contribution?
No
How was the solution tested?
Covered by existing tests (this is a refactoring)