Backport "Remove dead large class detection" to 3.3 LTS - #1051
Open
tgodzik wants to merge 1 commit into
Open
Conversation
While looking at scala#25989 I noticed the message this code is trying to catch doesn't exist in our fork nor in stock ASM since we upstreamed changes https://gitlab.ow2.org/asm/asm/-/merge_requests/181/diffs In practice any such exception will be caught by the next case in the catch anyway. I didn't try to write a test that triggers JVM code size limits because they're apparently [extremely high](https://stackoverflow.com/a/42299271). ## How much have you relied on LLM-based tools in this contribution? Not at all ## How was the solution tested? Covered by existing tests (this is a refactoring) [Cherry-picked e8a13bb][modified]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports scala#26212 to the 3.3.9.
PR submitted by the release tooling.
[skip ci]