This repository was archived by the owner on Oct 24, 2025. It is now read-only.
Fix segfault by defining the asset_url function in the right context#148
Open
botandrose wants to merge 1 commit intosass:masterfrom
Open
Fix segfault by defining the asset_url function in the right context#148botandrose wants to merge 1 commit intosass:masterfrom
botandrose wants to merge 1 commit intosass:masterfrom
Conversation
Author
|
Okay, Travis is green! What do you think? |
Member
|
@botandrose is there anyway to test this change? Is this backwards compatible? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I hit a segfault upon upgrading my app to to Sprockets 4.0, and eventually tracked it down to this.
I also think it might be the same issue as this: rails/sprockets#633 (comment)