fix(rootcolor): only apply the background image to :root; improve all root(color|scrolllock|scrollgutter) #4354
+23
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- only :root needs to cover the scrollbar gutter - applying background to data-theme will break background for themes applied in dropdown (see theme generator - CSS viewer)
…lllock) - use space variables to avoid need for if() - use background-image and background-color instead of full background - only apply changed background-color on :root (avoid changing the backgrounds for themed elements) - move styles from modal and drawer in rootscrollgutter where they belong, and only control if they need to be applied from modal and drawer
pdanpdan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation: