use v4 auth with CloudFront#457
Open
nidi3 wants to merge 1 commit intos3tools:masterfrom
Open
Conversation
Contributor
|
Thanks for the attempt. I agree this is a bug; I don't think this is quite the right fix though. I don't understand why we need to change sign_string_v4(). hard-coded region string clearly isn't right. |
Author
There was a problem hiding this comment.
This is to avoid problems with header values that contain spaces
Author
|
Sorry for the poor quality of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a hack that works for me.
I don't know Python nor s2cmd good enough to assure that it is fully correct.