Support grouping by multiple fields with @indexBy directive#1
Merged
Conversation
```graphql
{
customers {
edges @indexby(field: "node.id,node.name") {
node {
id
name
}
}
}
}
```
Generates the following code:
```php
/**
* @var array<int,array<string,CustomerEdge>>
*/
public array $edges {
get => $this->edges ??= (function() {
$result = [];
foreach ($this->data['edges'] as $item) {
$result[$item['node']['id']][$item['node']['name']] = new CustomerEdge($item);
}
return $result;
})();
}
```
shahinataei-ts
added a commit
to shahinataei-ts/graphql-client-code-generator
that referenced
this pull request
Dec 16, 2025
When processing ListOfType in mapGraphQLTypeToPHPType, the $builtInOnly
parameter was incorrectly passed as the second argument ($nullable)
instead of the third argument ($builtInOnly).
This caused the $builtInOnly parameter to default to false when
processing list items, resulting in the PHP mapped type being used
instead of the primitive JSON type in $data parameter docblocks.
Example of the bug:
- GraphQL: currencies: [Currency!]!
- Config: withScalar('Currency', Type::string(), Type::object(Currency::class))
- Generated docblock: 'currencies': list<Currency> (wrong)
- Should be: 'currencies': list<string> (correct)
This caused PHPStan errors like:
"Parameter ruudk#1 $code of class Money\Currency constructor expects
non-empty-string, Money\Currency given."
shahinataei-ts
added a commit
to shahinataei-ts/graphql-client-code-generator
that referenced
this pull request
Dec 16, 2025
When processing ListOfType in mapGraphQLTypeToPHPType, the $builtInOnly
parameter was incorrectly passed as the second argument ($nullable)
instead of the third argument ($builtInOnly).
This caused the $builtInOnly parameter to default to false when
processing list items, resulting in the PHP mapped type being used
instead of the primitive JSON type in $data parameter docblocks.
Example of the bug:
- GraphQL: currencies: [Currency!]!
- Config: withScalar('Currency', Type::string(), Type::object(Currency::class))
- Generated docblock: 'currencies': list<Currency> (wrong)
- Should be: 'currencies': list<string> (correct)
This caused PHPStan errors like:
"Parameter ruudk#1 $code of class Money\Currency constructor expects
non-empty-string, Money\Currency given."
ruudk
pushed a commit
that referenced
this pull request
Dec 16, 2025
When processing ListOfType in mapGraphQLTypeToPHPType, the $builtInOnly
parameter was incorrectly passed as the second argument ($nullable)
instead of the third argument ($builtInOnly).
This caused the $builtInOnly parameter to default to false when
processing list items, resulting in the PHP mapped type being used
instead of the primitive JSON type in $data parameter docblocks.
Example of the bug:
- GraphQL: currencies: [Currency!]!
- Config: withScalar('Currency', Type::string(), Type::object(Currency::class))
- Generated docblock: 'currencies': list<Currency> (wrong)
- Should be: 'currencies': list<string> (correct)
This caused PHPStan errors like:
"Parameter #1 $code of class Money\Currency constructor expects
non-empty-string, Money\Currency given."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{ customers { edges @indexBy(field: "node.id,node.name") { node { id name } } } }Generates the following code: