-
-
Notifications
You must be signed in to change notification settings - Fork 279
Add bernoulli naive bayes implementation #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #388 +/- ##
==========================================
+ Coverage 35.90% 36.03% +0.13%
==========================================
Files 97 99 +2
Lines 6409 6502 +93
==========================================
+ Hits 2301 2343 +42
- Misses 4108 4159 +51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kakserpom
pushed a commit
to kakserpom/linfa
that referenced
this pull request
Jun 10, 2025
* Add bernoulli Naive Bayes algorithm * Remove optional from `FitWith` trait implementation * Move class histogram to root path; Improve example * Make NaiveBayes public * Add predict_log_proba and predict_proba * Review * Linting * Revert lint to preserve MSRV * Add serde for ClassHistogram * Bump MSRV to 1.82.0 --------- Co-authored-by: Art Wild <[email protected]> Co-authored-by: Lorenz Schmidt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #242
Moreover,
NaiveBayes
trait is made public as suggested in this comment and provides sklearn-like methodspredict_log_proba()
andpredict_proba()
as mentioned in this commentThis PR resolves #183 and also supersedes #385