Fix to 128 bit int unaligned loads #684
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoyo
reviewed
May 23, 2025
| @@ -924,7 +924,9 @@ impl<'a, 'gcc, 'tcx> BuilderMethods<'a, 'tcx> for Builder<'a, 'gcc, 'tcx> { | |||
| // dereference after a drop, for instance. | |||
| // FIXME(antoyo): this check that we don't call get_aligned() a second time on a type. | |||
| // Ideally, we shouldn't need to do this check. | |||
| let aligned_type = if pointee_ty == self.cx.u128_type || pointee_ty == self.cx.i128_type { | |||
| let aligned_type = if (pointee_ty == self.cx.u128_type || pointee_ty == self.cx.i128_type) | |||
There was a problem hiding this comment.
Could you please add a comment to explain why you do this?
| @@ -924,7 +924,9 @@ impl<'a, 'gcc, 'tcx> BuilderMethods<'a, 'tcx> for Builder<'a, 'gcc, 'tcx> { | |||
| // dereference after a drop, for instance. | |||
| // FIXME(antoyo): this check that we don't call get_aligned() a second time on a type. | |||
| // Ideally, we shouldn't need to do this check. | |||
| let aligned_type = if pointee_ty == self.cx.u128_type || pointee_ty == self.cx.i128_type { | |||
| let aligned_type = if (pointee_ty == self.cx.u128_type || pointee_ty == self.cx.i128_type) | |||
| && align == Align::from_bytes(16).unwrap() | |||
There was a problem hiding this comment.
Instead of hard-coding the alignment, could you query it from the Rust compiler like we do here?
Seems it is possibly executed many times, it might be better to store this result in CodegenCx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the segfault caused by packed structs containing u128 / i128. #683
I also added a test to detect any regressions like this in the future.