modifed y.sh to allow for running cargo tests. #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoyo
reviewed
May 9, 2025
Contributor
antoyo
left a comment
antoyo
left a comment
There was a problem hiding this comment.
Good job!
Could you please update the doc and the CI to use this new command instead of cargo test?
antoyo
reviewed
May 10, 2025
Contributor
antoyo
left a comment
antoyo
left a comment
There was a problem hiding this comment.
I like how you add a lot of comments.
Thanks!
antoyo
reviewed
May 10, 2025
FractalFir
force-pushed
the
y_cargo_tests
branch
3 times, most recently
from
c80276e to
9da753c
Compare
antoyo
reviewed
May 25, 2025
FractalFir
force-pushed
the
y_cargo_tests
branch
6 times, most recently
from
8a8bf33 to
32fa765
Compare
Contributor
Author
|
Should be good to merge now. |
antoyo
reviewed
May 27, 2025
Contributor
Author
|
Should be good for review now. |
antoyo
reviewed
May 28, 2025
Contributor
antoyo
left a comment
antoyo
left a comment
There was a problem hiding this comment.
Very nice work.
One last thing that I missed.
Contributor
Author
|
Should be OK to merge now. I split the enviroment variable changes into a separate commit, just in case it turns out something still needed that. |
antoyo
approved these changes
May 28, 2025
Contributor
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new option to
./y.sh test:./y.sh test --cargo-tests.When this option is selected,
y.shwill build & test minicore(it is a dependency). After that, it will simply callcargo testwith the selected environment flags.For now
./y.sh test --cargo-testsignoresRUSTFLAGS.Normally,
RUSTFLAGScontain the-Zcodegen-backendoption, which would makecg_gccrebuild itself. This is undesirable, and ignoringRUSTFLAGSaltogether was simply the easiest option.In the future, we maybe could filter out
-Zcodegen-backend, and keep the rest of the flags intact.