Update incremental-compilation.md#1903
Closed
Tbkhi wants to merge 2284 commits intorust-lang:masterfrom
Closed
Conversation
Co-authored-by: Yuki Okushi <[email protected]>
"Getting Started" is already *very* long; this shrinks it a bit, and puts similar info closer together.
This is advanced info that most contributors won't need to know; and for experienced contributors, it means the info is at the top of the page instead of needing to scroll.
There was a lot of information duplicated between the two, and it wasn't clear which one to look. This commit changes `contributing.md` to be strictly for contribution procedures, and moves "what should I work on" sections to "Getting Started". This also consolidates the links in `about-this-guide.md` rather than spreading them between about-this-guide, getting-started, and contributing. I suggest using https://rustc-dev-guide.org/git.html#moving-large-sections-of-code to review this commit.
This is already covered in detail on Forge: https://forge.rust-lang.org/infra/toolstate.html and linked in the previous paragraph.
Co-authored-by: Yuki Okushi <[email protected]>
since this method has been renamed in rustc. Also remove a link to documentation in error-guaranteed.md because it was unused
Co-authored-by: Tshepang Mbambo <[email protected]>
These were removed in 2021. rust-lang/rust#85993
Minor updates to markup and an edit for clarity.
Contributor
Author
|
CC: @spastorino |
jieyouxu
added
the
S-waiting-on-review
jieyouxu
added
T-compiler
Member
|
Sorry, due to me messing up a git operation, we sadly had to force-push the whole commit history of rustc-dev-guide :( If you'd like to update this pull request, you will have to rebase it in a special way onto the new commit history (the new More context can be found here. |
jieyouxu
added
S-stale
Member
|
Hi, thank you for your contribution and sorry for the lack of reviews. Given that unfortunately this has accrued a lot of conflicts and seems unlikely to receive a meaningful review anytime soon, I will close this PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor updates to markup and an edit for clarity.