rustc_expand: improve diagnostics for non-repeatable metavars#152679
Open
Unique-Usman wants to merge 2 commits intorust-lang:mainfrom
Open
rustc_expand: improve diagnostics for non-repeatable metavars#152679Unique-Usman wants to merge 2 commits intorust-lang:mainfrom
Unique-Usman wants to merge 2 commits intorust-lang:mainfrom
Conversation
…tition Enhance `NoSyntaxVarsExprRepeat` by suggesting similarly named metavariables, distinguishing repeatable vs non-repeatable bindings, and listing available repeatable variables when no match exists. Co-authored-by: Esteban Küber <esteban@kuber.com.ar> Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
rustbot
added
S-waiting-on-review
Collaborator
|
r? @BoxyUwU rustbot has assigned @BoxyUwU. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
r? @estebank |
Contributor
Author
|
This is rebased on top of ->791ee34 |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Esteban Küber <esteban@kuber.com.ar> Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
Unique-Usman
force-pushed
the
ua/decmacrounrepeatable
branch
from
0fbe120 to
81f68bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.