Skip to content

Conversation

@Enselic
Copy link
Member

@Enselic Enselic commented Oct 25, 2025

Split out from #147799 because these seemingly simple corrections can turn out to be non-trivial. See #147728 for example.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 25, 2025
@rustbot

This comment was marked as outdated.

@Enselic
Copy link
Member Author

Enselic commented Oct 25, 2025

Re-rolling reviewer since Mark-Simulacrum is already assigned to #147728 and I want to spread the load.

r? compiler

@rustbot rustbot assigned jackh726 and unassigned Mark-Simulacrum Oct 25, 2025
@Zalathar
Copy link
Contributor

@bors try jobs=x86_64-msvc-1,i686-msvc-1

rust-bors bot added a commit that referenced this pull request Oct 25, 2025
tests/debuginfo/closures.rs: Activate misspelled `cdb-check`

try-job: x86_64-msvc-1
try-job: i686-msvc-1
@rust-bors

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Oct 25, 2025

☀️ Try build successful (CI)
Build commit: a11f19e (a11f19eb2d175d49117f9da104486af3c0ccf01a, parent: 04ff05c9c0cfbca33115c5f1b8bb20a66a54b799)

@Zalathar
Copy link
Contributor

This passed try jobs, so let's just merge it without further ceremony.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 26, 2025

📌 Commit 76b9c23 has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 26, 2025
…lathar

tests/debuginfo/closures.rs: Activate misspelled `cdb-check`

Split out from rust-lang#147799 because these seemingly simple corrections can turn out to be non-trivial. See rust-lang#147728 for example.
bors added a commit that referenced this pull request Oct 26, 2025
Rollup of 4 pull requests

Successful merges:

 - #145665 (Don't require `T: RefUnwindSafe` for `vec::IntoIter<T>: UnwindSafe`)
 - #147728 (tests: activate misspelled `gdb-check` in `function-arg-initialization.rs`)
 - #148097 (tests/debuginfo/closures.rs: Activate misspelled `cdb-check`)
 - #148118 (Improve the ICE message for invalid nullary intrinsic calls)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 26, 2025
…lathar

tests/debuginfo/closures.rs: Activate misspelled `cdb-check`

Split out from rust-lang#147799 because these seemingly simple corrections can turn out to be non-trivial. See rust-lang#147728 for example.
bors added a commit that referenced this pull request Oct 26, 2025
Rollup of 2 pull requests

Successful merges:

 - #148097 (tests/debuginfo/closures.rs: Activate misspelled `cdb-check`)
 - #148118 (Improve the ICE message for invalid nullary intrinsic calls)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Oct 26, 2025
tests/debuginfo/closures.rs: Activate misspelled `cdb-check`

Split out from #147799 because these seemingly simple corrections can turn out to be non-trivial. See #147728 for example.
@bors
Copy link
Collaborator

bors commented Oct 26, 2025

⌛ Testing commit 76b9c23 with merge 3bcdb11...

@Zalathar
Copy link
Contributor

Failed in rollup in aarch64-msvc-1: #148127 (comment)

@bors r- retry

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 26, 2025
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants