perf: removed unnecessary let for return only in layout.rs #148093
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perf: removed unnecessary let for return only
rustbot
added
S-waiting-on-review
|
This won't have any performance impact. At best it could make the code nicer to look at. |
hkBst
approved these changes
Oct 26, 2025
| let align_m1 = unchecked_sub(align.as_usize(), 1); | ||
| let size_rounded_up = unchecked_add(self.size, align_m1) & !align_m1; | ||
| size_rounded_up | ||
| unchecked_add(self.size, align_m1) & !align_m1 |
There was a problem hiding this comment.
The commentary above already contains the same information as the let-for-comment-binding, so I suppose getting rid of it is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perf: removed unnecessary let for return only