parse const trait Trait
#143879
Merged
parse const trait Trait
#143879
+365
−299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
|
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang This PR changes a file inside Some changes occurred to the CTFE machinery Some changes occurred in src/tools/clippy cc @rust-lang/clippy HIR ty lowering was modified cc @fmease Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt Some changes occurred in compiler/rustc_attr_parsing rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
This comment has been minimized.
This comment has been minimized.
fee1-dead
force-pushed
the
push-lrlpoouyqqry
branch
from
fbc7508 to
49ab742
Compare
This comment has been minimized.
This comment has been minimized.
fee1-dead
force-pushed
the
push-lrlpoouyqqry
branch
from
49ab742 to
4e9b986
Compare
This comment has been minimized.
This comment has been minimized.
fee1-dead
force-pushed
the
push-lrlpoouyqqry
branch
from
4e9b986 to
b782ee2
Compare
|
This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #143888) made this pull request unmergeable. Please resolve the merge conflicts. |
fmease
reviewed
Jul 13, 2025
Comment on lines
881
to
882
| || self.check_keyword(exp!(Const)) && (self.is_keyword_ahead(1, &[kw::Trait]) | ||
| || self.is_keyword_ahead(1, &[kw::Unsafe]) && self.is_keyword_ahead(2, &[kw::Trait, kw::Auto])) |
There was a problem hiding this comment.
This doesn't admit const auto trait Trait {}, it should tho (it already allows const unsafe auto trait Trait {}). Ofc for that const auto needs to be followed by trait so we don't regress const auto: () = ();.
fmease
approved these changes
Jul 14, 2025
There was a problem hiding this comment.
I don't think this file should be modified? This will just fail in r-a's repo after the sync bc r-a doesn't impl the new syntax (we currently don't run r-a's tests in r-l/r's CI).
There was a problem hiding this comment.
I think it's fine, we actually parse const trait and the tests still run with that change.
fee1-dead
force-pushed
the
push-lrlpoouyqqry
branch
from
b782ee2 to
124c33e
Compare
|
r? fmease |
|
|
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 16, 2025
…y, r=fmease parse `const trait Trait` r? oli-obk or anyone from project-const-traits cc ``@rust-lang/project-const-traits``
bors
added
S-waiting-on-author
fee1-dead
force-pushed
the
push-lrlpoouyqqry
branch
from
124c33e to
f62b29b
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup |
|
☔ The latest upstream changes (presumably #144044) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
|
@bors p=1 bitrotty |
fee1-dead
force-pushed
the
push-lrlpoouyqqry
branch
from
f62b29b to
6932687
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
fmease
added a commit
to fmease/rust
that referenced
this pull request
Jul 17, 2025
…y, r=fmease parse `const trait Trait` r? oli-obk or anyone from project-const-traits cc `@rust-lang/project-const-traits`
fmease
added a commit
to fmease/rust
that referenced
this pull request
Jul 17, 2025
…y, r=fmease parse `const trait Trait` r? oli-obk or anyone from project-const-traits cc ``@rust-lang/project-const-traits``
bors
added a commit
that referenced
this pull request
Jul 17, 2025
Rollup of 15 pull requests Successful merges: - #142300 (Disable `tests/run-make/mte-ffi` because no CI runners have MTE extensions enabled) - #143271 (Store the type of each GVN value) - #143293 (fix `-Zsanitizer=kcfi` on `#[naked]` functions) - #143719 (Emit warning when there is no space between `-o` and arg) - #143833 (Ban projecting into SIMD types [MCP838]) - #143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests) - #143879 (parse `const trait Trait`) - #143891 (Port `#[coverage]` to the new attribute system) - #143967 (constify `Option` methods) - #143985 (rustc_public: de-StableMIR-ize) - #144008 (Fix false positive double negations with macro invocation) - #144010 (Boostrap: add warning on `optimize = false`) - #144034 (tests: Test line number in debuginfo for diverging function calls) - #144049 (rustc-dev-guide subtree update) - #144056 (Copy GCC sources into the build directory even outside CI) r? `@ghost` `@rustbot` modify labels: rollup
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing bf5e6cc (parent) -> 9cd918b (this PR) Test differencesShow 214 test diffsStage 1
(and 103 additional test diffs) Additionally, 11 doctest diffs were found. These are ignored, as they are noisy. Job group index Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 9cd918bcbbc26deb005eb4e1bd9a445380195e56 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (9cd918b): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -3.0%, secondary -1.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 2.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 464.659s -> 464.098s (-0.12%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? oli-obk or anyone from project-const-traits
cc @rust-lang/project-const-traits