Closes report doctest line numbers in a clickable format #143839
+284
−294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
rustbot
added
A-compiletest
This comment has been minimized.
This comment has been minimized.
|
rustbot has assigned @GuillaumeGomez. Use |
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
jieyouxu
reviewed
Jul 13, 2025
Comment on lines
+2275
to
+2283
| if let Some((left, _)) = s.split_once(" - ") { | ||
| let path_with_line = left.rsplit("test ").next().unwrap(); | ||
| let (path, line_number) = | ||
| path_with_line.rsplit_once(":").expect("line number not found"); | ||
| let path = fs::canonicalize(&path).expect("failed to canonicalize"); | ||
| let path = path.to_str().unwrap().replace('\\', "/"); | ||
| if let Some(ref mut v) = files.get_mut(&path) { | ||
| tested += 1; | ||
| let mut iter = right.split("(line "); | ||
| iter.next(); | ||
| let line = iter | ||
| .next() | ||
| .unwrap_or(")") | ||
| .split(')') | ||
| .next() | ||
| .unwrap_or("0") | ||
| .parse() | ||
| .unwrap_or(0); | ||
| if let Ok(pos) = v.binary_search(&line) { | ||
| if let Ok(pos) = v.binary_search(&line_number.parse::<usize>().unwrap_or(0)) { |
There was a problem hiding this comment.
Discussion: hm, this seems rather fragile 🤔 But I don't feel like blocking on this.
There was a problem hiding this comment.
What would you recommend? Didn't want to change much of the logic here since s is the entire test name.
| @@ -1,7 +1,7 @@ | |||
|
|
|||
| running 2 tests | |||
| test doctest.rs - (line 4) ... ok | |||
| test doctest.rs - init (line 8) ... ok | |||
| test doctest.rs:4 ... ok | |||
There was a problem hiding this comment.
The output is much less good though...
GuillaumeGomez
requested changes
Jul 13, 2025
rustbot
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #142984
Added a change to the add the line number to the file name to make it clickable