Skip to content

Implement check for compiletest and RA using tool macro #143816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Implement check for compiletest and RA using tool macro #143816

wants to merge 3 commits into from
+63 −140

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Jul 11, 2025 •
edited
Loading

Small cleanup to reduce the number of places that require custom check steps. Of course I had to include one mini hack because of Rust Analyzer.. but I think it's worth it here.

r? @jieyouxu

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 11, 2025
@Kobzol Kobzol mentioned this pull request Jul 17, 2025
Open
@Kobzol Kobzol force-pushed the compiletest-check-macro branch from 5552ce8 to 43f4652 Compare July 19, 2025 18:56
@Kobzol Kobzol marked this pull request as ready for review July 19, 2025 18:56
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 19, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Jul 19, 2025

Rebased.

@Kobzol Kobzol force-pushed the compiletest-check-macro branch from 43f4652 to e68f5fe Compare July 20, 2025 20:49
jieyouxu
jieyouxu approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macro feels like it's getting a bit unwieldy because of the combinations it has to account for... But anyway, not for this PR. Thanks!

@jieyouxu
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 21, 2025

📌 Commit e68f5fe has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kobzol @jieyouxu @bors @rustbot