Skip to content

Constify Try, From, TryFrom and relevant traits #143768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Constify Try, From, TryFrom and relevant traits #143768

wants to merge 1 commit into from
+204 −299

Conversation

Randl
Copy link
Contributor

@Randl Randl commented Jul 11, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jul 11, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 11, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Randl
Copy link
Contributor Author

Randl commented Jul 11, 2025

I can reproduce the fail locally but I do not understand why it happens and how it is related to the changes.

@bors
Copy link
Collaborator

bors commented Jul 13, 2025

☔ The latest upstream changes (presumably #143888) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk
oli-obk reviewed Jul 17, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jul 17, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jul 18, 2025
View reviewed changes
@Randl
Copy link
Contributor Author

Randl commented Jul 19, 2025

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned davidtwco Jul 19, 2025
@Randl Randl mentioned this pull request Jul 20, 2025
Open
@oli-obk
Copy link
Contributor

oli-obk commented Jul 20, 2025

Please squash the commits when CI is green

oli-obk
oli-obk reviewed Jul 21, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jul 21, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jul 21, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jul 21, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jul 21, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jul 21, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jul 21, 2025
View reviewed changes
@oli-obk
Copy link
Contributor

oli-obk commented Jul 21, 2025

Please squash when the last comment has been addressed

@oli-obk oli-obk mentioned this pull request Jul 18, 2025
Open
3 tasks
@oli-obk
Copy link
Contributor

oli-obk commented Jul 21, 2025

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 21, 2025

📌 Commit 3c76e3d has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Randl @rustbot @rust-log-analyzer @bors @oli-obk @davidtwco