-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Drop ./x suggest
#143630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Drop ./x suggest
#143630
Conversation
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
This is quite a bit of implementation complexity, yet it is quite broken, and we don't have the maintenance bandwidth to address. Remove the current implementation if only to reduce bootstrap's implementation complexity; the `suggest` flow comes with its own set of hacks.
rustbot has assigned @Mark-Simulacrum. Use |
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang This PR modifies If appropriate, please update These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
This PR removes the current
./x suggest
implementation (#109933, #106249) and associated docs for several reasons:./x suggest
is another "flow" in bootstrap that incurs extra complexity and more invariants that bootstrap has to maintain. This causes more friction when trying to investigate and fix staging problems. As far as I know, this flow has not been actively maintained in quite a while, and I'm not aware of interest in maintaining it. Bootstrap really could use less implementation complexity with a very limited maintenance bandwidth../x suggest
implementation "bypasses" the usual stage defaults for the various check/build/test/etc. flows, and it's not really possible to have a stage default because./x suggest --run
produces a sequence of suggestions like [./x check
,./x test library/std
, ..] and then tries to run all of them in sequence, based on which files are modified.x suggest
entries for testingmir-opt
andcoverage
#117961 and Suggest pattern tests when modifying exhaustiveness #120763. I'm not convinced the extra implementation complexity is worth it. This was discussed in:Closes #109933 (the current implementation is being removed).
Closes #143569 (by removing
./x suggest
altogether).