Port #[path] to the new attribute parsing infrastructure
#143344
Merged
+123
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
JonathanBrouwer
changed the title
#[path] to the new attribute parsing infrastructure
JonathanBrouwer
commented
Jul 2, 2025
| @@ -267,6 +267,36 @@ pub fn check_builtin_meta_item( | |||
| deny_unsafety: bool, | |||
| ) { | |||
| if !is_attr_template_compatible(&template, &meta.kind) { | |||
| // attrs with new parsers are locally validated so excluded here | |||
There was a problem hiding this comment.
This move is in a separate commit for reviewability.
It is needed because
JonathanBrouwer
commented
Jul 2, 2025
| @@ -26,6 +26,7 @@ use crate::attributes::link_attrs::{LinkNameParser, LinkSectionParser}; | |||
| use crate::attributes::lint_helpers::{AsPtrParser, PubTransparentParser}; | |||
| use crate::attributes::loop_match::{ConstContinueParser, LoopMatchParser}; | |||
| use crate::attributes::must_use::MustUseParser; | |||
| use crate::attributes::path::PathParser as PathAttributeParser; | |||
There was a problem hiding this comment.
Needed because this file contains an unrelated thing called PathParser already
|
☔ The latest upstream changes (presumably #143338) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
JonathanBrouwer
force-pushed
the
path-parser
branch
from
f18c6f3 to
02fb831
Compare
|
^ Rebased on master |
rustbot
added
S-waiting-on-review
|
|
|
Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_attr_data_structures Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
|
☔ The latest upstream changes (presumably #143434) made this pull request unmergeable. Please resolve the merge conflicts. |
Signed-off-by: Jonathan Brouwer <[email protected]>
Signed-off-by: Jonathan Brouwer <[email protected]>
JonathanBrouwer
force-pushed
the
path-parser
branch
from
02fb831 to
244d64e
Compare
|
@jdonszelmann ^ Rebased on master |
jdonszelmann
approved these changes
Jul 6, 2025
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 7, 2025
Rollup of 9 pull requests Successful merges: - #143206 (Align attr fixes) - #143236 (Stabilize `mixed_integer_ops_unsigned_sub`) - #143344 (Port `#[path]` to the new attribute parsing infrastructure ) - #143359 (Link to 2024 edition page for `!` fallback changes) - #143456 (mbe: Change `unused_macro_rules` to a `DenseBitSet`) - #143529 (Renamed retain_mut to retain on LinkedList as mentioned in the ACP) - #143535 (Remove duplicate word) - #143544 (compiler: rename BareFn to FnPtr) - #143552 (lib: more eagerly return `self.len()` from `ceil_char_boundary`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 7, 2025
Rollup merge of #143344 - JonathanBrouwer:path-parser, r=jdonszelmann Port `#[path]` to the new attribute parsing infrastructure Ports `#[path]` to the new attribute parsing infrastructure for #131229 (comment) This PR duplicates a change from #143237 Draft until that one is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports
#[path]to the new attribute parsing infrastructure for #131229 (comment)This PR duplicates a change from #143237
Draft until that one is merged