Port `#[target_feature]` to new attribute parsing infrastructure #142876

JonathanBrouwer · 2025-06-22T15:10:58Z

Ports target_feature to the new attribute parsing infrastructure for #131229 (comment)

compiler/rustc_attr_parsing/src/attributes/mod.rs

compiler/rustc_passes/src/check_attr.rs

obi1kenobi · 2025-06-22T15:16:45Z

This should probably bump the rustdoc JSON FORMAT_VERSION too. This attribute is used by cargo-semver-checks today, and should probably also be in the rustdoc JSON test suite as well.

cc @aDotInTheVoid purely for awareness

JonathanBrouwer · 2025-06-22T15:18:16Z

Ah, I missed it because it's not part of the tests for rustdoc-json. I'll make sure to give this attribute the nice formatting too, and to bump the FORMAT_VERSION

obi1kenobi · 2025-06-22T15:30:42Z

Ah, I missed it because it's not part of the tests for rustdoc-json. I'll make sure to give this attribute the nice formatting too, and to bump the FORMAT_VERSION

You are my favorite person!

Just noting that this attribute has three valid forms:

it can be repeated on the same item, like #[target_feature(enable = "one")] #[target_feature(enable = "another")]
it can have multiple enable clauses, like #[target_feature(enable = "one", enable = "another")], and
it can have multiple features in the same enable clause, like #[target_feature(enable = "one,another")]

I believe any mix of these is also legal. For nice formatting, I don't have strong feelings how we normalize so long as we do normalize if at all possible. The last form is the most compact and IIRC how the attribute is explained in the docs, so all else equal that's what I'd pick if I were choosing. But feel free to do whatever is easiest.

And yes, entirely reasonable to miss it since we never tested it. We never tested it because it's only the new cargo-semver-checks releasing ~this week that uses it :)

JonathanBrouwer · 2025-06-22T15:32:29Z

I encountered these the hard way when writing the attribute :p I discover so much about Rust when doing these refactorings
Actually, since I do the pretty printing, does the FORMAT_VERSION even need to be bumped? Or does the normalizing count as a change?

rustbot · 2025-06-22T15:37:12Z

These commits modify tests/rustdoc-json.
rustdoc-json is a public (but unstable) interface.

Please ensure that if you've changed the output:

It's intentional.
The FORMAT_VERSION in src/librustdoc-json-types is bumped if necessary.

cc @aDotInTheVoid, @obi1kenobi

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

JonathanBrouwer · 2025-06-22T15:38:14Z

This push should fix the pretty printing for rustdoc. Thanks for the feedback <3
I didn't end up bumping the FORMAT_VERSION but if I need to lmk

obi1kenobi · 2025-06-22T16:24:51Z

I think normalizing to an already-valid form doesn't need to bump the format version, since any downstream consumers would have had to be able to handle it already.

JonathanBrouwer · 2025-06-22T17:15:09Z

@rustbot ready
r? @jdonszelmann

rustbot · 2025-06-22T17:15:13Z

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

compiler/rustc_codegen_ssa/src/codegen_attrs.rs

compiler/rustc_passes/src/check_attr.rs

src/librustdoc/clean/types.rs

tests/ui/target-feature/invalid-attribute.stderr

jdonszelmann · 2025-06-22T17:31:55Z

@rustbot author

rustbot · 2025-06-22T17:31:59Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

bors · 2025-06-22T21:12:38Z

☔ The latest upstream changes (presumably #142878) made this pull request unmergeable. Please resolve the merge conflicts.

JonathanBrouwer · 2025-06-22T21:13:16Z

Fixed the issues above & rebased on master
@rustbot ready

bors · 2025-06-23T10:39:12Z

☔ The latest upstream changes (presumably #142901) made this pull request unmergeable. Please resolve the merge conflicts.

compiler/rustc_attr_parsing/src/attributes/mod.rs

compiler/rustc_codegen_ssa/src/target_features.rs

rustbot · 2025-07-01T22:08:13Z

Some changes occurred to constck

cc @fee1-dead

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

JonathanBrouwer · 2025-07-01T22:10:25Z

^ I think I processed all your feedback @oli-obk
@rustbot ready

bors · 2025-07-03T03:28:09Z

☔ The latest upstream changes (presumably #143338) made this pull request unmergeable. Please resolve the merge conflicts.

Signed-off-by: Jonathan Brouwer <[email protected]>

JonathanBrouwer · 2025-07-03T05:54:31Z

^ Rebased

oli-obk · 2025-07-03T08:21:02Z

@bors r+

bors · 2025-07-03T08:21:05Z

📌 Commit 3d5d72b has been approved by oli-obk

It is now in the queue for this repository.

…ser, r=oli-obk Port `#[target_feature]` to new attribute parsing infrastructure Ports `target_feature` to the new attribute parsing infrastructure for rust-lang#131229 (comment) r? `@jdonszelmann`

Rollup of 6 pull requests Successful merges: - #134006 (setup typos check in CI) - #142876 (Port `#[target_feature]` to new attribute parsing infrastructure) - #143038 (avoid suggesting traits from private dependencies) - #143083 (Fix rustdoc not correctly showing attributes on re-exports) - #143283 (document optional jobs) - #143329 (minicore: use core's `diagnostic::on_unimplemented` messages) Failed merges: - #143237 (Port `#[no_implicit_prelude]` to the new attribute parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #142876 - JonathanBrouwer:target_feature_parser, r=oli-obk Port `#[target_feature]` to new attribute parsing infrastructure Ports `target_feature` to the new attribute parsing infrastructure for #131229 (comment) r? ``@jdonszelmann``

Rollup of 6 pull requests Successful merges: - rust-lang/rust#134006 (setup typos check in CI) - rust-lang/rust#142876 (Port `#[target_feature]` to new attribute parsing infrastructure) - rust-lang/rust#143038 (avoid suggesting traits from private dependencies) - rust-lang/rust#143083 (Fix rustdoc not correctly showing attributes on re-exports) - rust-lang/rust#143283 (document optional jobs) - rust-lang/rust#143329 (minicore: use core's `diagnostic::on_unimplemented` messages) Failed merges: - rust-lang/rust#143237 (Port `#[no_implicit_prelude]` to the new attribute parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

JonathanBrouwer commented Jun 22, 2025

View reviewed changes

compiler/rustc_attr_parsing/src/attributes/mod.rs Outdated Show resolved Hide resolved

compiler/rustc_passes/src/check_attr.rs Show resolved Hide resolved

compiler/rustc_passes/src/check_attr.rs Show resolved Hide resolved

JonathanBrouwer force-pushed the target_feature_parser branch from 8dd448b to 34dd949 Compare June 22, 2025 15:37

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2025

rustbot assigned jdonszelmann Jun 22, 2025

jdonszelmann reviewed Jun 22, 2025

View reviewed changes

compiler/rustc_codegen_ssa/src/codegen_attrs.rs Outdated Show resolved Hide resolved

compiler/rustc_passes/src/check_attr.rs Show resolved Hide resolved

src/librustdoc/clean/types.rs Outdated Show resolved Hide resolved

tests/ui/target-feature/invalid-attribute.stderr Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2025

JonathanBrouwer force-pushed the target_feature_parser branch from 34dd949 to c14ebc4 Compare June 22, 2025 19:37

JonathanBrouwer force-pushed the target_feature_parser branch from c14ebc4 to 33e67cb Compare June 22, 2025 21:13

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 22, 2025

jdonszelmann mentioned this pull request Jun 23, 2025

Tracking issue: Attribute refactor #131229

Open

9 tasks

rustbot unassigned jdonszelmann Jun 28, 2025

JonathanBrouwer force-pushed the target_feature_parser branch from 1256cdd to 15f0320 Compare June 29, 2025 10:55

JonathanBrouwer mentioned this pull request Jun 30, 2025

Rewrite empty attribute lint for new attribute parser #143252

Draft

oli-obk requested changes Jul 1, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2025

JonathanBrouwer force-pushed the target_feature_parser branch from 15f0320 to fd6da8f Compare July 1, 2025 22:08

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 1, 2025

This comment has been minimized.

Sign in to view

JonathanBrouwer force-pushed the target_feature_parser branch from fd6da8f to 7605dad Compare July 1, 2025 22:17

Port #[target_feature] to the new attribute parsing infrastructure

3d5d72b

Signed-off-by: Jonathan Brouwer <[email protected]>

JonathanBrouwer force-pushed the target_feature_parser branch from 7605dad to 3d5d72b Compare July 3, 2025 05:54

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2025

This was referenced Jul 3, 2025

Rollup of 6 pull requests #143362

Closed

Rollup of 6 pull requests #143363

Merged

bors merged commit 5026d0c into rust-lang:master Jul 3, 2025
10 checks passed

rustbot added this to the 1.90.0 milestone Jul 3, 2025

Port #[target_feature] to new attribute parsing infrastructure #142876

Port #[target_feature] to new attribute parsing infrastructure #142876

Conversation

JonathanBrouwer commented Jun 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

obi1kenobi commented Jun 22, 2025

Uh oh!

JonathanBrouwer commented Jun 22, 2025

Uh oh!

obi1kenobi commented Jun 22, 2025

Uh oh!

JonathanBrouwer commented Jun 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 22, 2025

Uh oh!

JonathanBrouwer commented Jun 22, 2025

Uh oh!

obi1kenobi commented Jun 22, 2025

Uh oh!

JonathanBrouwer commented Jun 22, 2025

Uh oh!

rustbot commented Jun 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jdonszelmann commented Jun 22, 2025

Uh oh!

rustbot commented Jun 22, 2025

Uh oh!

bors commented Jun 22, 2025

Uh oh!

JonathanBrouwer commented Jun 22, 2025

Uh oh!

bors commented Jun 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Jul 1, 2025

Uh oh!

JonathanBrouwer commented Jul 1, 2025

Uh oh!

This comment has been minimized.

bors commented Jul 3, 2025

Uh oh!

JonathanBrouwer commented Jul 3, 2025

Uh oh!

oli-obk commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

Uh oh!

Uh oh!

Port `#[target_feature]` to new attribute parsing infrastructure #142876

Port `#[target_feature]` to new attribute parsing infrastructure #142876

JonathanBrouwer commented Jun 22, 2025 •

edited

Loading