-
Notifications
You must be signed in to change notification settings - Fork 13.4k
We rely on an undocumented property of GetUserProfileDirectoryW #141254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This was referenced May 19, 2025
Wait, I recognise that name. I'd completely forgot about writing that. |
|
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
May 23, 2025
… r=ChrisDenton GetUserProfileDirectoryW is now documented to always store the size Update to match MicrosoftDocs/sdk-api#1810 Also fix a bug in the Miri implementation while I am starting at that code... r? `@ChrisDenton` Fixes rust-lang#141254
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
May 24, 2025
… r=ChrisDenton GetUserProfileDirectoryW is now documented to always store the size Update to match MicrosoftDocs/sdk-api#1810 Also fix a bug in the Miri implementation while I am starting at that code... r? ``@ChrisDenton`` Fixes rust-lang#141254
rust-timer
added a commit
that referenced
this issue
May 24, 2025
Rollup merge of #141405 - RalfJung:GetUserProfileDirectoryW, r=ChrisDenton GetUserProfileDirectoryW is now documented to always store the size Update to match MicrosoftDocs/sdk-api#1810 Also fix a bug in the Miri implementation while I am starting at that code... r? ```@ChrisDenton``` Fixes #141254
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this issue
May 26, 2025
… r=ChrisDenton GetUserProfileDirectoryW is now documented to always store the size Update to match MicrosoftDocs/sdk-api#1810 Also fix a bug in the Miri implementation while I am starting at that code... r? ```@ChrisDenton``` Fixes rust-lang#141254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The docs say that the size is written on failure, but in practice it is also written on success and we rely on that. See #141244 and rust-lang/miri#4332.
We shouldn't use system APIs outside their documented contract, so we should either adjust our implementation or get Microsoft to update the docs to promise this behavior we have been relying on.
Cc @ChrisDenton
The text was updated successfully, but these errors were encountered: