Remove dependencies #3153
Merged
Remove dependencies #3153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
rm-deps
branch
2 times, most recently
from
482f318 to
5ee7188
Compare
GuillaumeGomez
force-pushed
the
rm-deps
branch
from
5ee7188 to
7a8c7da
Compare
syphar
approved these changes
Jan 21, 2026
Member
syphar
left a comment
syphar
left a comment
There was a problem hiding this comment.
I see what you mean, let's do it.
Will also keep that in mind for other things.
github-actions
bot
added
S-waiting-on-deploy
Member
Author
|
I think there isn't much more to be done after this PR on this track. Might have missed some things but at least all the obvious ones were removed. |
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit removes an unused dependency. The other commits though "inline" the dependency when it was only for very minor things. It's all up-to-debate (well except the first commit 😄). :)